fix: clone sig metadata properties #4316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue's impacting latest docker images. So we should release a new minor after merging and testing. |
rscampos
force-pushed
the
fix_issue_4313_sig
branch
from
0b164b1
to
73523cf
Compare
rscampos
force-pushed
the
fix_issue_4313_sig
branch
from
73523cf
to
a4fbfe3
Compare
- bump sig helpers
rscampos
force-pushed
the
fix_issue_4313_sig
branch
from
a4fbfe3
to
7b32e95
Compare
|
Forgive me for asking, but are we any better off now than the original version where the function just returned the metadata as a struct? So maybe we have now (at best) (mem footprint)=original-(no copy)+(clone the properties). |
|
I think you’re right, @NDStrahilevitz. Initially, we saw a performance improvement, but then an issue arose. After discussing it with @geyslan, we’re considering a rollback. Thanks! |
|
We're already reverted related changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4298
fix: #4313
1. Explain what the PR does
0b164b1 fix: clone sig metadata properties
2. Explain how to test it
3. Other comments